Enhancement: Add support for Blazar leases

[barnes-c]

Hi,

I would like to bring leases into ORC
I would like to get some feedback on this enhancement idea.

In gophercloud/gophercloud#4031 I heard that this would be a welcome addition.

Im not quite sure though how to contribute in small patches.
I see, the PRs in this repo go up to 10k LOC, which, I assume, makes reviewing very hard.

I already have a working test version of this running

[winiciusallan]

Hi @barnes-c, I haven't taken a thorough look at your enhancement, but at a first glance, we usually don't require enhacements for new controllers, unless it has some design decision that we should care about. Would be this the case?

Besides that, a good starting point is our documentation. Fortunately, we've been using a commit struct for our PRs that's making reviews much easier.

You could do, for example, a first PR adding the bulk of the work with all fields immutable, and then pushing additional PRs for mutability and other capabilities.

Thanks for your contributions!

[barnes-c]

@winiciusallan thanks for the quick response!

I was reading the CONTRIBUTING.md until the submitting new changes section, which says to create an enhancement PR...
Below it, it says how to add a new controller, oops

Will look into this!

[mandre]

As @winiciusallan said, unless we need to discuss new patterns (#948 is a good example), there's no need to create an enhancement proposal for new controllers. I think we can close this PR.

Looking forward to the new Lease controller 😃
Don't hesitate to ask on slack if you're stuck or have any question regarding the implementation.