Repository navigation
Conversation
Without a capabilities.untrustedWorkspaces declaration, VS Code disables the extension in Restricted Mode. Declare full support: the extension never runs workspace code. What an untrusted workspace can still control is its settings, and two of them were interpolated raw into the webview's <style> block. csv.cellPadding went in unchecked, and the font family fell back to editor.fontFamily (workspace-settable) with only \ and " escaped. Either could close the <style> element and inject markup, such as an https: image beacon, which the CSP allows. wrapHtml now sanitizes the font family, font size and cell padding itself, so every render path is covered. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Note sure if you'd want this or not, but I sure find it handy to be able to edit CSV files in untrusted repos (a bit paranoid of my agents!). I only lightly reviewed the test and don't personally have a good handle on your test conventions - sorry if it's a bit slop! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without a capabilities.untrustedWorkspaces declaration, VS Code disables
the extension in Restricted Mode. Declare full support: the extension
never runs workspace code.
What an untrusted workspace can still control is its settings, and two of
<style> element and inject markup, such as an https: image beacon, which the CSP allows. wrapHtml now sanitizes the font family, font size and cell padding itself, so every render path is covered.them were interpolated raw into the webview's <style> block. csv.cellPadding
went in unchecked, and the font family fell back to editor.fontFamily
(workspace-settable) with only \ and " escaped. Either could close the