Repository navigation
FIX register() misses libraries listed before it was called - #287
Merged
Merged
Conversation
Clear the cache of unmatched libraries, and the controller returned by get_cached_controller(), when a new controller is registered. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 29, 2026
itamarst
approved these changes
Oct 29, 2026
| """ | ||
| # Run in a subprocess to keep the registered controller out of the other | ||
| # tests: | ||
| path = os.path.dirname(os.path.dirname(__file__)) |
Contributor
There was a problem hiding this comment.
The custom env seems unnecessary (I think it got copied from some other test, which probably doesn't need it either).
Contributor
Author
There was a problem hiding this comment.
It seems you're right. Should I remove it in the other test too in this PR?
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ogrisel
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #249, libraries that no controller matches are cached as unsupported for the lifetime of the process.
register()doesn't clear that cache, or the one behindget_cached_controller(), so a custom controller never finds a library that was listed before it was registered:This regression hasn't been released, so there is no changelog entry.
🤖 Generated with Claude Code