Repository navigation
PERF New get_cached_controller() API #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
itamarst
wants to merge
16
commits into
joblib:master
Choose a base branch
from
itamarst:254-cached-controller-api
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+185
−5
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
64e0d55
New get_cached_controller() API.
itamarst 65e2a6a
Pacify black
itamarst 2348bfa
Handle edge cases better.
itamarst e20d20d
Correct PR number
itamarst efc4870
Fix typo
itamarst 791f46e
Test for FlexiBLAS cached controller invalidation.
itamarst de4a375
Fix a race condition
itamarst 9394e08
Fix spurious Windows test failure
itamarst d29ff6f
Just do normal assert
itamarst f8266d3
Address review comments
itamarst 3f982e2
Fast path
itamarst 30198f5
Reformat
itamarst 6c57a68
Reformat with ruff
itamarst 7a0ff21
Merge branch 'master' into 254-cached-controller-api
itamarst 68a954b
Add cache invalidation API
itamarst 85a1406
Update threadpoolctl.py
itamarst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| """Test script for ``_get_cached_controller``.""" | ||
|
|
||
| from threadpoolctl import ( | ||
| ThreadpoolController, | ||
| get_cached_controller, | ||
| reset_cached_controller, | ||
| ) | ||
|
|
||
| controller = get_cached_controller() | ||
| assert isinstance(controller, ThreadpoolController) | ||
| # Same controller is returned on another call: | ||
| assert controller is get_cached_controller() | ||
| # No libraries loaded: | ||
| assert len(controller.lib_controllers) == 0 | ||
|
|
||
| import numpy as np # noqa: F401 (also gets us BLAS) | ||
|
|
||
| # Now a new controller is returned: | ||
| controller2 = get_cached_controller() | ||
| assert controller is not controller2 | ||
| assert isinstance(controller2, ThreadpoolController) | ||
| # And it noticed the newly loaded controllable library: | ||
| assert len(controller2.lib_controllers) >= 1 | ||
|
|
||
| # reset_cached_controller() clears the cache: | ||
| assert get_cached_controller() is controller2 | ||
| reset_cached_controller() | ||
| controller3 = get_cached_controller() | ||
| assert controller3 is not controller2 | ||
| assert get_cached_controller() is controller3 | ||
|
|
||
|
|
||
| # Special success exit code: | ||
| raise SystemExit(17) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.