Repository navigation
Fix EnumMap lookups for enum constants with class bodies - #1190
Merged
jknack merged 1 commit intoOct 3, 2026
Merged
Conversation
jknack
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EnumMap lookups fail when the first key is an enum constant with a class body. Its runtime class is a subclass of the enum, so passing getClass() to Enum.valueOf rejects valid keys.
Use getDeclaringClass() to resolve the key against the enum type. Add regression tests for dotted and bracketed paths, the lookup helper, missing and null values, empty maps, and unknown constant names.
Fixes #1083.
Validation: