Repository navigation
chore: cut the v1.12.0 changelog - #98
Merged
Merged
Conversation
Leads with Security: the --exec key leak, the key echoed in errors, the GH_HOST port and mismatch, and the unforwarded SIGINT are in released versions, so each item names the ones it affects, as the basis for an advisory. Six changes are under Changed, among them --exec revoking the token, the GH_HOST refusal, and tokens reporting Valid() == false inside the skew rather than oauth2's 10s.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 9 9
Lines 935 935
=======================================
Hits 914 914
Misses 21 21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dates the v1.12.0 entry for #87 to #96. Security leads: the
--execkey leak, the key echoed in errors, theGH_HOSTport and mismatch, and the unforwarded SIGINT are in released versions, so each item names the versions it affects, as the basis for a security advisory. Six changes are under Changed, including--execrevoking the token, theGH_HOSTrefusal, and tokens reportingValid() == falseinside the skew. An adversarial Codex check against the code corrected the affected versions and added that last item.After merge, tagging
v1.12.0on main runs the release workflow: binaries, the Homebrew cask, and the first gh extension release.