Repository navigation
chore: record the 0.3.0 oracle run and keep local paths out of results - #26
Merged
Merged
Conversation
# Conflicts: # research/04-edge-case-catalog.md
Deploying simple-excel with
|
| Latest commit: |
e14e300
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1ddb8661.simple-excel.pages.dev |
| Branch Preview URL: | https://chore-oracle-v0-3-0.simple-excel.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things: it commits the pre-release oracle run for 0.3.0, and it stops oracle and benchmark results from recording local machine details. It adds no library code.
1. Oracle run for 0.3.0
This is the
npm run oracle -- --tag kind:goldenrun that AGENTS.md asks for before a release. It ran onmainafter #23 (src/identical) and covers all 31 golden fixtures across nine readers, including Excel and LibreOffice.canonical,inlineandzip64, the Google Sheets and Excel on the web re-saves of our output, and the header-offset and Salesforce report goldens.<v>inf</v>for the 1.79e308 cell.2026-09-12-phase-d-simple-excel-goldenrun fixture for fixture, so fix: harden the reader against hostile files, fix Node sink hangs, and classify every error #23's reader changes moved nothing.research/05-compatibility-matrix.mdis regenerated and now includes this run.2. No local paths or hostnames in committed results
Reader errors, LibreOffice convert messages, stack traces and fixture paths carried absolute paths, which include the macOS username. The results also recorded the hostname, and the repo is public.
scripts/lib/local-paths.mjs.oracle/run.mjs,bench/run.mjsandbench/lib/chrome.mjsnow write the repo root as<repo>and the home directory as~.hostas<platform>-<arch>(for exampledarwin-arm64). The bench no longer records a hostname, and new bench result folders are named<date>-<platform>-<arch>-<label>. Existing folder names are unchanged.oracle/results,bench/resultsandresearch/06) are scrubbed the same way, with hostnames replaced bydarwin-arm64.main's history, which this PR doesn't do.