Upgrade makefile-modules to pick up the latest base image - #844
Merged
Merged
Conversation
- Run `make upgrade-klone` and `make generate`. - Moves base-static to sha256:357d77bf and base-static-csi to sha256:66ac2470, the digests upstream makefile-modules now pins. - Also bumps the vendored build tools, including helm 4.3.0, goreleaser 2.18.2, syft 1.52.0 and govulncheck 1.8.0. Go stays at 1.27.1, which is the latest release. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Richard Wall <richard.wall@cyberark.com>
wallrj-cyberark
added
test-ark
test-e2e
maelvls
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the three agent images to the latest
quay.io/jetstack/base-staticbefore we release v1.12.0.We pin
base-static@sha256:dc719ea4…. Upstream makefile-modules has since moved tosha256:357d77bf…(cert-manager/makefile-modules#752 and cert-manager/makefile-modules#753), which is also the current:latest. This PR runsmake upgrade-kloneandmake generateto pick that up.The same upgrade bumps the vendored build tools. Several are used by the release workflow: helm 4.2.4 to 4.3.0, goreleaser 2.18.0 to 2.18.2 and syft 1.51.1 to 1.52.0. Go stays at 1.27.1, the latest release.
Please add the
test-e2e,test-arkandtest-ngtslabels before merging, so the e2e suites run against the new base image and tools.How I tested it: verify, unit tests, local image builds scanned with trivy
make verifypasses, including golangci-lint (0 issues.).make test-unit: 465 tests, 4 skipped, 0 failures.make oci-build-preflight__local oci-build-ark__local oci-build-ngts__localbuilds all three images. Each ko config showsdefaultBaseImageatsha256:357d77bf….trivy image --ignore-unfixed(0.72.0) on each local build: 0 fixable vulnerabilities in all three. Trivy saw the Alpine 3.23 base and the Go binary in each, and inventoried 105 packages in thedisco-agentimage.make verify-govulncheck: no called vulnerabilities. The one uncalled finding, GO-2026-5932 (golang.org/x/crypto/openpgpis unmaintained), has no fixed version.For comparison, the
v1.12.0-alpha.1images on quay also scan at 0 fixable vulnerabilities. So this is routine upkeep before a GA release, not a CVE fix.Every tool version that changes
[with Claude]