small upgrades of logging for GTNH - #4304
Merged
Merged
Conversation
itzg
approved these changes
Oct 1, 2026
itzg
left a comment
itzg
left a comment
Owner
There was a problem hiding this comment.
Logs do look better. And nice refactoring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this will be of any help for someone but i did it anyway !
GTNH_PACK_VERSION=latest-beta.
-BEFORE-
Selected "2.9.0-RC-1" as latest beta version for download.
-AFTER- NO CHANGE
Selected "2.9.0-RC-1" as latest beta version for download.
GTNH_PACK_VERSION=latest.
-BEFORE-
Selected "2.8.4" as latest version for download.
-AFTER- NO CHANGE
Selected "2.8.4" as latest version for download.
GTNH_PACK_VERSION=2.9.0-RC-1.
-BEFORE-
Selected 2.9.0-RC-1 as matching version for download.
-AFTER- Brackets
Selected "2.9.0-RC-1" as matching version for download.
GTNH_PACK_VERSION=2.10.0.
-BEFORE-
Selected as matching version for download.
[ERROR] No release found for GTNH_PACK_VERSION=2.10.0. Please check if the version is valid.
-AFTER- No log before error
[ERROR] No release found for GTNH_PACK_VERSION=2.10.0. Please check if the version is valid.
gtnh_versions_json_url="https://downloads.gtnewhorizons.com/versions.j".
-BEFORE-
curl: (22) The requested URL returned error: 404
Selected as latest beta version for download.
[ERROR] No release found for GTNH_PACK_VERSION=latest-beta. Please check if the version is valid.
-AFTER- No log before error and better explaination
curl: (22) The requested URL returned error: 404
[ERROR] Failed to download from "https://downloads.gtnewhorizons.com/versions.j"