Repository navigation
Fall back to the GitHub mirror when cloning Eigen fails - #277
Merged
Merged
Conversation
- Probe GitLab with git ls-remote before CPM clones Eigen - Key the CPM cache on the tag so both sources share one copy Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
9 tasks done
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
=======================================
Coverage 96.97% 96.98%
=======================================
Files 221 221
Lines 22426 22426
Branches 1540 1539 -1
=======================================
+ Hits 21747 21749 +2
+ Misses 679 677 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Lets the Eigen CPM recipe (
cmake/recipes/eigen.cmake) fall back to the GitHub mirror when GitLab can't be reached. Cloning from GitLab fails often enough in CI to break the wheel builds.CPMAddPackageruns, agit ls-remotecall (30 s timeout) checks that GitLab has the tag. If it doesn't answer, the recipe warns and clones fromeigen-mirror/eigeninstead.CPMAddPackageis a fatal error and can't be retried, so the source has to be picked before CPM runs._deps,CPM_eigen_SOURCEis set, orFETCHCONTENT_FULLY_DISCONNECTEDis on.CUSTOM_CACHE_KEY 5.0.1makes both sources share${CPM_SOURCE_CACHE}/eigen/5.0.1. Both have tag5.0.1at the same commit,bc3b398.Impacts:
Also documents the branch naming convention (
^(feature|bugfix|fix|refactor|docs|chore|test|release)/.+, exceptmain,v[0-9.]*, andgh-pages) inCLAUDE.md.Type of change
How Has This Been Tested?
I configured a minimal project that includes the recipe, using an empty
CPM_SOURCE_CACHE. To simulate an outage, I redirectedgitlab.comto a dead address through git'surl.<base>.insteadOfsetting.bc3b398, no warning.bc3b398from the GitHub mirror.-DIPC_TOOLKIT_BUILD_TESTS=ON) succeeds with the new cache layout.Test Configuration:
Checklist