Repository navigation
Conversation
isc-dchui
requested review from
isc-cborbonm,
isc-egabhart,
isc-eneil,
isc-jili,
isc-jlechtne,
isc-kiyer and
isc-tleavitt
as code owners
November 6, 2026 17:49
isc-tleavitt
requested changes
Nov 6, 2026
isc-tleavitt
self-requested a review
November 6, 2026 21:01
isc-tleavitt
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #806, fixes #503, fixes #150
generatewrote web applications with%Installer.CSPApplicationattribute names inside<WebApplication>, which validates every attribute againstSecurity.Applications, so generated modules with a web app failed to load. This also fixes two smaller gaps:generateonPasswordAuthEnabled,Url,DeployPath, ... rejected on loadSecurity.Applicationsproperty namesMyApp.Local.AandMyApp.Local.BMyApp.PKGMyApp.Local.PKGtests/folder<UnitTest>with the classes' shared packageSecurity.Applications.Getreturns is written if it differs from its default, because those defaults are whatWebApplicationcreates the app with.NameandNameSpacecome from the install, andIsNameSpaceDefaultis left out so installing the module doesn't take over the namespace's default app.AutheEnabledis always written so a reader can see how the app authenticates.Pathbecomes{$cspdir}. Other directories, such asWSGIAppLocation, keep this instance's path.<WebApplication>doesn't deploy files the way<CSPApplication SourcePath>did, so a CSP app's source files get a<FileCopy>to itsPath. ThatFileCopyreplaces its target on load and removes it on uninstall, so loading a generated module on the instance it came from swaps the app's directory for the module's copy..PKGper top-level package. Being narrower than before, it won't cover a package added later outside it, such asMyApp.Othernext toMyApp.Local.PKG..PKGresources. Every<UnitTest>getsPhase="test", including integration tests.generatewith an error instead of writing a module.xml with no code.Testing
New
Test.PM.Integration.GenerateandTest.PM.Unit.ModuleTemplate. The web app test deletes the apps it generated from and loads the module to recreate them.Checklist
mainbranch rebased or merged.zpm test -only) and integration tests (zpm verify -only) pass.🤖 Generated with Claude Code