Repository navigation
Sampling flag propagation - #537
Open
arjun-rajappa wants to merge 11 commits into
Open
arjun-rajappa wants to merge 11 commits into
arjun-rajappa wants to merge 11 commits into
Conversation
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
…d consume Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
…server Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Keep only the newest run of each workflow name and the latest attempt of each job, so reruns no longer fail the coverage report or mix in stale results. Also accept an optional WORKFLOW_ID to resolve the pipeline, exit early when the pipeline or workflows cannot be found, and skip jobs without a coverage artifact. Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Sampling decisions (the Instana level, or the W3C sampled flag) were being dropped when a trace crossed async or messaging boundaries. A suppressed trace could therefore resume as sampled downstream. Several instrumentations also ignored W3C
traceparent/tracestateor didn't inject them.What
extract_context, which keepslevelfrom the Instana payload and falls back to W3Ctraceparent/tracestateinjob.__otel_headers. Removed theTraceParent::REGEXPmonkey patch.X_INSTANA_T/S/Lmessage attributes onpublish.X-INSTANA-T/S/Linto the client context oninvoke. If a client context already exists, merge into it instead of skipping.traceparentandtracestate. The consumer extracts context from the Instana headers, or from the W3C headers if those are missing.x-instana-l,traceparentandtracestate. The server extracts context from either header set viaextract_grpc_context.X-Instana-Lis absent, derive the level from the W3C sampled bit.X-Instana-Lstill takes priority.levelthrough the job payload and apply it in the worker, defaulting to 1.to_hashnow includeslevel.rubocop:disablecomments for the gRPC block length and theAwsTestclass length, and renamedtest_w3c_sampled_flag_sets_level_1to..._level_one.