Skip to content

ci: capture pytest exit codes and build test-status.json per label - #536

Open
CagriYonca wants to merge 1 commit into
masterfrom
currency-update
Open

CagriYonca wants to merge 1 commit into
masterfrom
currency-update

Conversation

@CagriYonca

@CagriYonca CagriYonca commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Why

The update-currency-versions job could start before the sibling test workflows and their auto-reruns had finished. It also stopped on the first failing library (set -e). As a result, rupy-currency-reporter could get incomplete dependency and test-status data.

How

  • New .circleci/wait_for_workflows.sh waits for all sibling workflows (including auto-reruns) to finish before versions are collected. It skips the wait with a warning if CIRCLE_TOKEN is not set.
  • run_bundle_list_and_test no longer stops the job on a failure. A failed bundle install or rake test writes FAIL to the library's status file and the job moves on to the next library.
  • Tests run with APPRAISAL_INITIALIZED=1, so only the selected gemfile's tests run.
  • update-currency-versions combines the per-library results into bundle-list/test-status.json ({"<library>": "fail"}; libraries that aren't listed passed). The file is published next to installed_*.txt.
  • The core workflow now uses requires: <job>: terminal, so the job runs whether the upstream jobs pass or fail.
  • The job now runs on Ruby 3.4 instead of 4.0 and installs jq and curl.

Verification

  • Checked that installed_*.txt, per-library status files and test-status.json are saved on both passing and failing runs.
  • Checked that the generated test-status.json works with rupy-currency-reporter (instana/rupy-currency-reporter#9).

@CagriYonca
CagriYonca requested a review from a team October 12, 2026 12:27
@CagriYonca CagriYonca self-assigned this Oct 12, 2026
@instana instana deleted a comment from github-actions Bot Oct 12, 2026
@instana instana deleted a comment from github-actions Bot Oct 12, 2026
@CagriYonca
CagriYonca force-pushed the currency-update branch 3 times, most recently from 30adaea to b56dac5 Compare October 13, 2026 08:27
@instana instana deleted a comment from github-actions Bot Oct 13, 2026
@instana instana deleted a comment from github-actions Bot Oct 13, 2026
@instana instana deleted a comment from github-actions Bot Oct 13, 2026
@instana instana deleted a comment from github-actions Bot Oct 13, 2026
@instana instana deleted a comment from github-actions Bot Oct 13, 2026
@instana instana deleted a comment from github-actions Bot Oct 13, 2026
@CagriYonca
CagriYonca marked this pull request as ready for review October 13, 2026 08:45
@CagriYonca CagriYonca added the ci label Oct 13, 2026
…ence

Signed-off-by: Cagri Yonca <cagri@ibm.com>
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant