Skip to content

Fix note and update documentation - #158

Merged
llrs-roche merged 16 commits into
mainfrom
157_note
Oct 28, 2026
Merged

llrs-roche merged 16 commits into
mainfrom
157_note

Conversation

@llrs-roche

Copy link
Copy Markdown
Contributor

Pull Request

Fixes #157

The function g_spiderplot() used id without prefixing with .data, now it doesn't create a note.
Also updated the documentation

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                   Stmts    Miss  Cover    Missing
-----------------------  -------  ------  -------  ---------
R/g_ae_sub.R                 346     346  0.00%    147-542
R/g_butterfly.R              183     183  0.00%    102-319
R/g_events_term_id.R         268     268  0.00%    129-498
R/g_heat_bygrade.R           210     210  0.00%    139-371
R/g_hy_law.R                  81      81  0.00%    119-203
R/g_patient_profile.R        392     392  0.00%    294-960
R/g_spiderplot_simple.R       27      27  0.00%    37-66
R/g_spiderplot.R             174     174  0.00%    109-345
R/g_swimlane.R               139     139  0.00%    119-320
R/g_waterfall.R              306     306  0.00%    146-506
R/stream_filter.R            125     125  0.00%    34-295
R/utils.R                    153     153  0.00%    43-362
TOTAL                       2404    2404  0.00%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  --------
R/g_patient_profile.R       +2      +2  +100.00%
TOTAL                       +2      +2  +100.00%

Results for commit: cad930a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@wangben718
wangben718 self-requested a review October 26, 2026 21:30
@wangben718 wangben718 self-assigned this Oct 26, 2026

@wangben718 wangben718 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! A few things before merging:

  1. R CMD check fails. The new mutate() in g_patient_profile() uses V1, an automatic column name from cbind(), which causes a "no visible binding" NOTE. Naming the column explicitly would fix it. The .data in that cbind() looks like a leftover too.
  2. R version requires bump up. I believe the native pipe |> needs R ≥ 4.1, but DESCRIPTION still says R (>= 3.6).
  3. Consider to add what has been changed in this PR to NEWS.md.

@wangben718 wangben718 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Please check the url check error on CI before merge.

@llrs-roche
llrs-roche merged commit f539505 into main Oct 28, 2026
29 checks passed
@llrs-roche
llrs-roche deleted the 157_note branch October 28, 2026 08:05
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Note on R CMD check

2 participants