Repository navigation
Fix note and update documentation - #158
Merged
Merged
Conversation
Contributor
Code Coverage SummaryDiff against mainResults for commit: cad930a Minimum allowed coverage is ♻️ This comment has been updated with latest results |
wangben718
self-requested a review
October 26, 2026 21:30
wangben718
requested changes
Oct 26, 2026
wangben718
left a comment
There was a problem hiding this comment.
Thanks for the fix! A few things before merging:
- R CMD check fails. The new
mutate()ing_patient_profile()usesV1, an automatic column name fromcbind(), which causes a "no visible binding" NOTE. Naming the column explicitly would fix it. The .data in that cbind() looks like a leftover too. - R version requires bump up. I believe the native pipe
|>needs R ≥ 4.1, but DESCRIPTION still says R (>= 3.6). - Consider to add what has been changed in this PR to NEWS.md.
wangben718
approved these changes
Oct 28, 2026
wangben718
left a comment
There was a problem hiding this comment.
Nice work. Please check the url check error on CI before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Fixes #157
The function
g_spiderplot()usedidwithout prefixing with.data, now it doesn't create a note.Also updated the documentation