Repository navigation
Fix history preview tab styling on replay (#7601) - #2331
Merged
Merged
Conversation
* chore: claim history preview tab fix * test(ok): cover history preview re-entry * fix(ok): retain history preview intent * docs(ok): note history preview fix * test(ok): cover pending history retry * fix(ok): retry pending history traversal * fix(ok): keep the history traversal marker until it resolves The hashchange handler cleared the traversal marker before resolving the target, so a re-entered call or a later effect run before the target became active opened it as a permanent tab. The marker now stays set until the next popstate replaces it, and the open path already returns early once the target is active. This replaces the token, second URL ref, acknowledgement effect, frozen disposition and per-branch retirement added earlier on this branch. * test(ok): cover a history traversal deferred while pages load A Back press handled while the page list is loading now opens its target as a preview once the list loads. The retry case drops two assertions on a test-local variable that nothing in the run could change. * test(ok): repeat every hashchange listener in the re-entry case The re-entry hook picked the app listener by a local identifier in its source text, so a rename left nothing wrapped and the test timed out on an unrelated poll. It now wraps every hashchange listener, repeats each one for the armed event, and fails with a named message when nothing was wrapped or repeated. * docs(ok): describe the history preview fix by its visible outcome * test(ok): name the no-op traversal case by its behavior The case title named a pending-traversal record and an acknowledgement step that the simplified fix no longer has. It now says what the case checks: a traversal whose open changed nothing opens as a preview again on the next render. * test(ok): settle the history traversal seed before its first click Both history traversal cases flaked during setup, before any Back press. On CI (Open Knowledge Validation run 40326960693, playwright shard 2, first attempt) the seeded hist-a row never rendered: earlier specs in the same worker had left dozens of root entries, so the virtualized tree did not render the new rows. Locally the click aimed at hist-a opened the fixture's sidebar-folder: the tree first rendered only the three seeded docs, then the full listing inserted sidebar-folder above them just as the click landed. The helper now seeds through api.seedDocs, which resets the worker's content to the fixture baseline and waits for the seeded pages, and it waits for every root entry of that content, the baseline entries included, before the first click. GitOrigin-RevId: aa5d90675a52c77b9b80cce0a683343975fdad41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copybara-translated 1 Inkeep OSS change. Rebase-merge this PR so the prepared commit lands directly on public main.