Repository navigation
linklayer: refactor: no default VLAN ID in the MAC forwarding table API - #1389
Merged
Merged
Conversation
Before this commit, the lookup and update methods of IMacForwardingTable, their overrides in MacForwardingTable, and the MRP-specific methods of MrpMacForwardingTable defaulted the VLAN ID to 0. A caller that forgot the VLAN of the frame compiled and silently used VLAN 0. The classic relays looked up destinations that way until d141d3f ("linklayer: fix: relays look up destinations in the VLAN of the frame"), and flooded tagged unicast frames, or sent them to a port learned for another VLAN. After this commit, every caller passes the VLAN ID, and a call without one does not compile. Every caller in INET already passes it, so the simulation does not change. Code outside INET that calls these methods without a VLAN ID must now pass one: 0 for VLAN-unaware use. The release note says so. Change: src.linklayer | refactor | whatsnew
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes the
=0default values fromunsigned int vidarguments in VLAN-related methods ofMacForwardingTable.Every caller in INET already passes the VLAN ID, so no additional adjustment was needed, and the simulations do not change.