Repository navigation
Conversation
Steveb-p
force-pushed
the
feature/narrow-language-id-6.0
branch
2 times, most recently
from
October 27, 2026 12:30
9d1a19e to
7649b7e
Compare
Steveb-p
force-pushed
the
feature/narrow-language-id-6.0
branch
2 times, most recently
from
October 30, 2026 13:13
dfa45de to
4eeb11a
Compare
Steveb-p
marked this pull request as ready for review
October 30, 2026 16:06
ibexa/core#801 renames ibexa_content_language to ibexa_language, and FixtureImporter skips fixture tables that don't exist, so the languages were silently left out. Its constructor also takes the schema assets filter bypass now, which the service definition didn't pass.
Points CI at the ibexa/core#801 branch, which renames the language table, so this branch can be tested before it merges.
Steveb-p
force-pushed
the
feature/narrow-language-id-6.0
branch
from
November 6, 2026 13:49
4eeb11a to
36e4dc7
Compare
alongosz
approved these changes
Nov 14, 2026
Collaborator
Author
|
Closing, ibexa/core#801 is dropped: the language ids stay BIGINT and the language table keeps its name, so there's nothing left to change here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This branch includes a temporary commit (
dependencies.json) that points CI at ibexa/core#801, so tests can run before that PR merges. Must be removed before merging this PR.Related PRs:
Description:
ibexa/core#801 renames
ibexa_content_languagetoibexa_language.FixtureImporterskips fixture tables that don't exist, so the languages intest_data.yamlwere silently left out, and packages' integration tests ran without any. Its constructor also takes aSchemaAssetsFilterBypassInterfacenow, whichtest.ibexa.fixture_importerdidn't pass. Core's ownTestKernelworks around that; packages using test-core get anArgumentCountError.Neither fix works without ibexa/core#801, so this lands together with it and the package PRs above.