Skip to content

IBX-13142: Pointed the test fixtures at core's renamed language table - #75

Closed
Steveb-p wants to merge 2 commits into
6.0from
feature/narrow-language-id-6.0
Closed

Steveb-p wants to merge 2 commits into
6.0from
feature/narrow-language-id-6.0

Conversation

@Steveb-p

@Steveb-p Steveb-p commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Warning

This branch includes a temporary commit (dependencies.json) that points CI at ibexa/core#801, so tests can run before that PR merges. Must be removed before merging this PR.

🎫 Issue IBX-13142

Related PRs:

Description:

ibexa/core#801 renames ibexa_content_language to ibexa_language. FixtureImporter skips fixture tables that don't exist, so the languages in test_data.yaml were silently left out, and packages' integration tests ran without any. Its constructor also takes a SchemaAssetsFilterBypassInterface now, which test.ibexa.fixture_importer didn't pass. Core's own TestKernel works around that; packages using test-core get an ArgumentCountError.

Neither fix works without ibexa/core#801, so this lands together with it and the package PRs above.

@Steveb-p
Steveb-p force-pushed the feature/narrow-language-id-6.0 branch 2 times, most recently from 9d1a19e to 7649b7e Compare October 27, 2026 12:30
@Steveb-p
Steveb-p force-pushed the feature/narrow-language-id-6.0 branch 2 times, most recently from dfa45de to 4eeb11a Compare October 30, 2026 13:13
@Steveb-p
Steveb-p marked this pull request as ready for review October 30, 2026 16:06
ibexa/core#801 renames ibexa_content_language to ibexa_language, and
FixtureImporter skips fixture tables that don't exist, so the languages
were silently left out. Its constructor also takes the schema assets
filter bypass now, which the service definition didn't pass.
Points CI at the ibexa/core#801 branch, which renames the language
table, so this branch can be tested before it merges.
@Steveb-p
Steveb-p force-pushed the feature/narrow-language-id-6.0 branch from 4eeb11a to 36e4dc7 Compare November 6, 2026 13:49
@Steveb-p Steveb-p changed the title IBX-11939: Pointed the test fixtures at core's renamed language table IBX-13142: Pointed the test fixtures at core's renamed language table Nov 13, 2026
@Steveb-p

Copy link
Copy Markdown
Collaborator Author

Closing, ibexa/core#801 is dropped: the language ids stay BIGINT and the language table keeps its name, so there's nothing left to change here.

@Steveb-p Steveb-p closed this Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants