Repository navigation
Conversation
…in tables Adds ibexa_content_translation and ibexa_content_version_translation (and ibexa_url_alias_ml_translation, which the same migration creates) and an always_available column on ibexa_content and ibexa_content_version, backfills them from the language masks, and switches the content and location gateways, the content mapper and the Filter to them. The content gateway keeps writing the masks and the always-available bit of the field and name language ids, which the remaining readers still use until the bitmask is removed. Adds the ibexa:languages:backfill-translations and ibexa:languages:verify-translations commands, and the new columns and rows to cleandata.sql. FixtureImporter fills the join tables for fixtures that still carry masks, and creates its SchemaAssetsFilterBypass itself when it isn't given one.
…illLanguageTranslationsMigration
…assed them to the Mapper
… in the language translation commands
…spectTableByUnquotedName()
…join table code IBX-13070 removed SchemaAssetsFilterBypass together with the filter it lifted, so the language translation commands and FixtureImporter introspect the connection directly again.
ibexa_search_object_word_link gets language_id and is_main_and_always_available columns, filled from its mask. The field criteria and sort clause, the full-text and language code criteria and the language filter of content and location search use the join tables and those columns instead of arithmetic on the masks. The indexer keeps writing the word link mask until the bitmask is removed, and field language ids are compared without their always-available bit until it is stripped.
…ws instead of loading content translations
…pes in the legacy search classes
…spectTableByUnquotedName()
ReindexCommand passes the --content-ids values as strings, and the untyped remove() hands them on to SearchIndex's int parameters, which strict types turned into a TypeError for deleted or unpublished content.
ibexa_url_alias_ml gets an is_always_available column, and an alias's languages come from ibexa_url_alias_ml_translation instead of lang_mask, in cleandata.sql too. The gateway keeps lang_mask in step with them until the bitmask is removed.
Content types read their languages from ibexa_content_type_name instead of decoding the type's language_mask, and resolve language ids through the language handler instead of MaskGenerator. They keep writing the mask and the always-available bit of their name rows until the bitmask is removed.
…pes in the content type mapper
Object states resolve language ids through the language handler instead of MaskGenerator. They keep writing the masks and the always-available bit until the bitmask is removed.
Stops writing the masks and drops them, together with MaskGenerator. New languages get the id after the highest one instead of the next power of two, which lifts the limit of 62 languages, and the always-available bit is stripped from the language_id columns, after removing the stale object state translations eZ Publish left behind.
…disagrees with them
…ge instead of the shape of the ids
…ead of refusing the delete
…en't a language, and from core's test data itself
…ed in languages beyond the old limit
… mapper and search index repository
…spectTableByUnquotedName()
… a seeded pre-6.0 database
…bitmask upgrade test IBX-13070 removed SchemaAssetsFilterBypass, and LegacySchemaImporter no longer takes one.
Steveb-p
force-pushed
the
feature/language-bitmask-upgrade-test-engines-6.0
branch
from
November 17, 2026 11:19
e38fec2 to
abe16fc
Compare
Steveb-p
force-pushed
the
feature/language-bitmask-6-remove-6.0
branch
from
November 17, 2026 11:19
3cbeb68 to
153157f
Compare
The names and fields of a version only matched its languages with the always-available bit added too, which the language ids don't carry anymore.
…SQL too Moved it to its own PHPUnit config, run by "composer integration" after the two integration suites, and made its setup portable.
Steveb-p
force-pushed
the
feature/language-bitmask-upgrade-test-engines-6.0
branch
from
November 17, 2026 11:50
abe16fc to
8682b71
Compare
|
Steveb-p
force-pushed
the
feature/language-bitmask-6-remove-6.0
branch
5 times, most recently
from
November 21, 2026 16:16
bcd1688 to
7f0bb8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Related PRs:
Description:
LanguageBitmaskUpgradeSequenceTest(#946) runs the whole language bitmask upgrade, from the always-available columns to the mask drop, on a seeded pre-6.0 database. It lives in the unit suite though, so CI only ever runs it on SQLite, and the MySQL and PostgreSQL SQL of those migrations (the strip's correlatedNOT EXISTS, the per-platform object stateDELETEs, the drop's guards) never runs anywhere but on our machines. Konrad pointed that out in #801 (comment), back when the test lived in #801.This moves the class to
tests/bundle/RepositoryInstaller/Migration/Upgrade/with its ownphpunit-migrations.xml, whichcomposer integrationruns after the two integration suites. Every integration job already calls that script, so CI runs the test on SQLite, PostgreSQL and MySQL, on both install paths, without touchingbackend-ci.yaml. It keeps its raw-connection base class, so the database comes fromDATABASE, which those jobs already set, and it runs last, so rebuilding a pre-6.0 schema intestdbcan't affect the other suites. The unit suite excludes the folder.The setup needed a few changes to work outside SQLite:
DEFAULT FALSEinstead ofDEFAULT 0for booleans, dropping the translation tables before importing the pre-6.0 schema (MySQL won't drop the tables they reference, and a pre-6.0 database doesn't have them anyway), anddropIndex()instead of a bareDROP INDEX.I'm not sure about this form yet, so opinions welcome :) What we considered:
backend-ci.yaml, running just this class withDATABASEset. Same coverage, but the workflow would name a test file, and decide what runs on which engine next to thephpunit*.xmlfiles.integration-legacysuite, which already runs on every engine. That's the setup we want to migrate away from, so I'd rather not add to it.phpunit-integration.xml. The bootstrapper installs the 6.0 schema once, into the database every kernel test after it uses, so rebuilding a pre-6.0 schema there would break them, and a separate database isn't possible with CI's MySQL user.composer integrationlocally.For QA:
No QA needed. To run it against a database:
DATABASE="pgsql://postgres:postgres@localhost:5432/testdb" vendor/bin/phpunit -c phpunit-migrations.xml