Skip to content

Update pack 3 - #7

Merged
SaadArdati merged 20 commits into
mainfrom
update-pack-3
Sep 28, 2026
Merged

Update pack 3#7
SaadArdati merged 20 commits into
mainfrom
update-pack-3

Conversation

@SaadArdati

@SaadArdati SaadArdati commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit d9f528e):

https://hyper-effects-demo--pr7-update-pack-3-eeil5hvw.web.app

(expires Mon, 05 Oct 2026 09:51:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5d002ef6bbfeabffe4f0fba43ae8da8f23db1f9f

@SaadArdati
SaadArdati requested review from BirjuVachhani and a balanced review from Copilot September 28, 2026 08:45
Copilot AI reviewed Sep 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@BirjuVachhani
BirjuVachhani requested a balanced review from Copilot September 28, 2026 09:11
Copilot AI reviewed Sep 28, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Timeline lifecycle, callback, controller-disposal, invalid-repeat, and color-filter keyframe issues remain unresolved.

Review effort: Balanced
Findings: 2 High severity · 3 Medium severity

Open (5)

Comment thread lib/src/animated_effect.dart
Comment thread lib/src/timeline/timeline_spec.dart
Comment thread .github/workflows/publish.yaml Outdated
Comment thread lib/src/timeline/timeline_controller.dart Outdated
Comment thread lib/src/timeline/timeline_effect.dart
@SaadArdati
Change return type of play and reverse methods
dc3f6ad 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI and others added 2 commits September 28, 2026 09:34
@SaadArdati
Fix idle filters for timeline late tracks
181b8ec 
Co-authored-by: SaadArdati <7407478+SaadArdati@users.noreply.github.com>
@SaadArdati
Rename and separate test steps in publish workflow
fb7c461 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@SaadArdati
Treat all negative timeline repeats as infinite
fa202bc 
Co-authored-by: SaadArdati <7407478+SaadArdati@users.noreply.github.com>
@SaadArdati
Guard queued drive after await with epoch check
d9f528e 
Co-authored-by: SaadArdati <7407478+SaadArdati@users.noreply.github.com>
@SaadArdati
SaadArdati requested a balanced review from Copilot September 28, 2026 09:49
Copilot AI reviewed Sep 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@SaadArdati
SaadArdati merged commit 64b1fb1 into main Sep 28, 2026
3 checks passed
SaadArdati added a commit that referenced this pull request Sep 28, 2026
@SaadArdati
Update Pack 3 - #7
fe15a90
@SaadArdati
SaadArdati deleted the update-pack-3 branch September 28, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@BirjuVachhani BirjuVachhani Awaiting requested review from BirjuVachhani
+1 more reviewer
Copilot code review Copilot Copilot left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SaadArdati @BirjuVachhani