Repository navigation
feat(tables): add layout property to table schemas - #175
Merged
Merged
Conversation
hotdata-automation
Bot
requested review from
zfarrell
and removed request for
a team
October 30, 2026 11:06
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| )] | ||
| pub last_sync: Option<Option<String>>, | ||
| #[serde(rename = "layout")] | ||
| pub layout: models::TableLayout, |
Contributor
There was a problem hiding this comment.
nit: (not blocking) Add #[serde(default)] to layout, or mark layout optional in the OpenAPI spec. A required layout makes TableInfo deserialization fail when a server response omits the field. Servers deployed before hotdata-dev/www#494 omit layout, so list-tables calls from this SDK version fail against those servers. TableLayout already implements Default (Analytical), so the fallback is safe. The TableInfo::new signature also changes. Mark that change as breaking in CHANGELOG.md for the next version bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated from the updated HotData OpenAPI spec.
Source: https://github.com/hotdata-dev/www/pull/494