[TDannhauer]

Summary

• Horde_Core_ActiveSync_Driver::changeMessage() returns ['error' => Horde_ActiveSync_Request_Sync::STATUS_INVALID] when the backend rejected the client's data (exception implementing Horde\Exception\InvalidDataThrowable), and keeps returning false for every other failure.
• The eight identical catch (Horde_Exception $e) blocks in changeMessage() are folded into one _importFailure() helper.

Part of horde/turba#73.

Motivation

Every changeMessage() failure was reported to the device as Status 5 (server error). Clients treat that as transient and resend the item on the next Sync — forever, when the backend will never accept the data (a Turba attribute over its configured maxlength, for example). Status 6 (STATUS_INVALID) tells the client to drop the change.

Changes

• lib/Horde/Core/ActiveSync/Driver.php
  • use Horde\Exception\InvalidDataThrowable;
  • changeMessage(): each catch (Horde_Exception $e) now does return $this->_importFailure($e, $folderid, $id); (previously _endBuffer(); return false; plus an err log). Docblock documents the new return shape.
  • _importFailure(Horde_Exception $e, $folderid, $id): ends output buffering; InvalidDataThrowable → warn ("Rejected client change for %s in folder %s: %s") and ['error' => STATUS_INVALID]; anything else → err($e->getMessage()) and false, as before.
• test/Unit/ActiveSync/DriverChangeMessageStatusTest.php (new): contact replace and contact import with an InvalidDataThrowable → STATUS_INVALID; plain Horde_Exception → false.

Exceptions

The caught type is unchanged (Horde_Exception, the ceiling in this legacy class). The handler only classifies it: an InvalidDataThrowable is an expected, tolerable condition caused by the client (logged at warn, item rejected with a status the client understands); anything else is still a server-side failure (logged at err, retryable Status 5). No exception is swallowed that was not swallowed before.

Dependencies

• InvalidDataThrowable from feat(exception): add InvalidDataThrowable marker interface Exception#6. Without it the instanceof check is simply never true and the old behaviour remains.
• feat(activesync): let backends set the per-item status of a failed change ActiveSync#111: Connector_Importer must honour ['error' => …]; with the current importer the array is truthy and treated as a stat array, so this PR should be merged after the ActiveSync one (or together).

Test plan

• DriverChangeMessageStatusTest (3 tests)
• Full test/Unit/ActiveSync suite: only the pre-existing failures in DriverMeetingResponseTest / DriverVersionCallbackTest (reproduced on pristine FRAMEWORK_6_0), nothing new
• Device test with fix(turba): enforce attribute constraints on every write path turba#74 and feat(activesync): let backends set the per-item status of a failed change ActiveSync#111: contact with an over-long ZIP → Status 6, device stops resending