Repository navigation
fix: bound retry attempt lookup by the failed attempt time - #1152
Merged
Merged
Conversation
This was referenced Oct 18, 2026
alexluong
force-pushed
the
fix/retry-lookup-time-bound
branch
2 times, most recently
from
October 19, 2026 20:09
67b9f51 to
8e822af
Compare
alexbouchardd
approved these changes
Oct 19, 2026
alexluong
force-pushed
the
fix/scheduler-receipt-delete
branch
from
October 21, 2026 15:31
cd7fce8 to
0c87e9b
Compare
alexluong
force-pushed
the
fix/retry-lookup-time-bound
branch
from
October 21, 2026 15:32
8e822af to
7470a22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bounds the retry scheduler's attempt lookup by the failed attempt's time.
Problem
Before publishing a retry, the scheduler looks up the latest attempt for the event and destination:
ClickHouse sorts
attemptsbyattempt_time, so without a time condition only the bloom skip indexes apply, and theevent_idbloom keeps ~2.5% of all granules as false positives. Each lookup reads the key columns of those granules, so its cost grows with retention.Fix
The latest attempt can't be older than the one that failed, so the retry task carries that attempt's time and the lookup starts there.
RetryTask.AttemptTime, set when the retry is scheduled.TimeFilter.GTE = AttemptTime - 1s(storage precision). All log store drivers already support it.AttemptTimeand run the unbounded query.8M attempts over 30 days, one lookup:
Notes
🤖 Generated with Claude Code