Repository navigation
Conversation
alexbouchardd
approved these changes
Oct 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With OpenTelemetry enabled, Outpost also exported telemetry from its dependencies: a span for every Redis command, spans and a latency histogram from the message queue clients, and gRPC spans and metrics from the Google Pub/Sub clients. Third-party instrumentation is now off by default;
OTEL_ENABLED_INSTRUMENTATIONSturns it back on per source. Outpost's own metrics, spans and audit logs and the HTTP server spans are unchanged.Breaking: upgrading an install with OpenTelemetry enabled
Without
OTEL_SERVICE_NAMEset, nothing changes.redisgocloud.dev/pubsub/latency, GCP Pub/Sub gRPC spans and metricsmqTo keep today's output:
Changes
SetupOTelSDKwraps the global tracer and meter providers in a filter on instrumentation scope (internal/otel/instrumentation.go). A dropped scope gets a noop meter and a tracer that records nothing and passes the parent span context through, so spans below a dropped span keep the right parent. Filtering at the provider covers gocloud.dev, which has no option to turn its instrumentation off.OTEL_ENABLED_INSTRUMENTATIONS(redis,mq); an unknown value fails config validation when OpenTelemetry is enabled.option.WithTelemetryDisabled(). Its gRPC telemetry has the same scope as the internal queue's, so it can't get its own key.Note:
mqmatches the otelgrpc scope, so a Google gRPC client added later follows themqkey unless it disables its own telemetry.🤖 Generated with Claude Code