Repository navigation
TEST (do not merge): GitHub rebase-merge check of the 105-commit series - #2
Closed
hjmjohnson wants to merge 91 commits into
Closed
hjmjohnson wants to merge 91 commits into
hjmjohnson wants to merge 91 commits into
Conversation
hjmjohnson
marked this pull request as ready for review
October 13, 2026 21:30
hjmjohnson
force-pushed
the
canny-dynamic-threading
branch
28 times, most recently
from
October 13, 2026 21:40
c2166a6 to
00a0f60
Compare
…n. Removed private InBounds met Applies ITK commit 0a20088c62a (2009-04-08) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies ITK commit 1608256c5a4 (2022-08-26) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies ITK commit 87a66198e11 (2022-09-25) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies these ITK commits to the copy of itk::CannyEdgeDetectionImageFilter: 2de7e24b0b5 (2022-12-01) STYLE: Use range-based `for` loops to iterate over `faceList` variables 18a672368d7 (2022-12-02) STYLE: Initialize `faceList` directly by ImageBoundaryFacesCalculator
Applies ITK commit 48c6ed76973 (2022-12-22) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies these ITK commits to the copy of
itk::CannyEdgeDetectionImageFilter:
5e2c49f9eb8 (2023-01-18) STYLE: Add in-class `{}` member initializers to objects created by New()
8f233d177ab (2023-03-04) STYLE: Add in-class `{}` member initializers having trailing comments
Applies ITK commit 5a60ed00adb (2023-03-07) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies ITK commit 2513f8f62e0 (2023-03-08) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies ITK commit 42b0bfc0771 (2023-03-09) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies ITK commit ed7ad92dd64 (2023-03-27) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies ITK commit f7fa2693f61 (2023-04-26) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies ITK commit 2c264ea2ef6 (2023-12-19) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies ITK commit 13ccff6af85 (2024-02-13) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies ITK commit 4d750726d06 (2024-03-01) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies these ITK commits to the copy of itk::CannyEdgeDetectionImageFilter: 7fd1e7341bd (2024-10-27) STYLE: Replace `Size var; var.Fill` with `auto var = Size::Filled` 6cb6bf98234 (2024-10-31) STYLE: Replace `T var; var.Fill(x)` with `auto var = MakeFilled<T>(x)` fd144827976 (2024-11-04) STYLE: Add constexpr to variables initialized by MakeFilled c77f9f8da0d (2024-11-09) STYLE: Add constexpr to variables initialized by T::Filled(int-literal) 677b76192a6 (2024-11-19) STYLE: Replace T::Pointer with auto when initializing variables by New()
Applies ITK commit 375ee8c47a0 (2024-11-27) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies ITK commit e1acaf5aa8d (2024-12-15) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies ITK commit 9e582fd86c0 (2025-01-23) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies ITK commit 097e2dc8788 (2025-01-23) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies ITK commit 1649dee8e42 (2025-04-17) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies ITK commit caa61aa3cdf (2025-06-10) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies ITK commit f46b4c93fec (2025-06-13) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies ITK commit cc5b30193fa (2026-02-11) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies ITK commit d086c8cf966 (2026-02-15) to the copy of itk::CannyEdgeDetectionImageFilter.
Applies these ITK commits to the copy of itk::CannyEdgeDetectionImageFilter: 50210af9d3b (2026-03-12) STYLE: Use CTAD for iterators "with index", in hxx files b6a38b188ca (2026-03-26) STYLE: Use CTAD for `ImageRegionIterator` variables in hxx files dbab3e0faba (2026-03-29) STYLE: Use CTAD when assigning an Image Iterator, in hxx files 4394f5d0eab (2026-04-03) STYLE: Move region iterator declarations into `for` loops over faces
The filter had no test of its own, only indirect use through the feature generators, so output values and re-execution were unchecked. Add tests that mirror ITK's CannyEdgeDetectionImageFilter tests: a baseline comparison and an A/B comparison after changing and restoring the thresholds on cthead1.png, the same A/B check on the 3D lesion volume, and tests of region start index, successive inputs of different sizes, parameters, hysteresis linking, and error handling. The baseline was generated by the filter before the ITK history was applied to it.
…Filter Drop an unused loop variable in the constructor and decoration on a comment so the file differs from the ITK filter only in its smoothing.
Deduction of ImageRegionIterator template arguments from its constructor needs deduction guides that ITK 5.4 does not provide, and the module is built against both ITK 5.4 and ITK 6.
hjmjohnson
force-pushed
the
canny-dynamic-threading
branch
from
October 13, 2026 21:41
00a0f60 to
eddcb77
Compare
Owner
Author
|
Throwaway PR used to test GitHub's rebase of the 105-commit series (limit found: 100 commits). Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway PR on my fork to test whether GitHub can rebase-merge the 105-commit series (InsightSoftwareConsortium#64) into a scratch base. Not for review; will be closed and its branches deleted.