Repository navigation
Set correct language on non-English example instruments - #146
Merged
Merged
Conversation
All example instruments were tagged "en". Since negation now follows the instrument language (harmonydata#143), this meant the Portuguese, French, German and Spanish GAD-7 examples were still negated with English rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All example instruments were tagged
"en", including the Portuguese, French, German and Spanish GAD-7. Since #143, negation follows the instrument language, so these examples were still negated with English rules. This sets the correct language code on the 11 non-English examples.Only
examples.pyis changed. No new dependencies.Type of change
Testing
Checked that each example's text matches its new language code, that all codes are valid in the
Languageenum, and that the examples still load.CI on my fork: 121 passed; 1 failed (test_convert_pdf, "Unable to start Tika server"), which is unrelated to this change.
Checklist
discordapp.com/users/1065327340994969671