Skip to content

BUG/MEDIUM: acme: append dns-01 records instead of replacing them #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjuraga merged 1 commit into from
Sep 28, 2026
Merged

BUG/MEDIUM: acme: append dns-01 records instead of replacing them #418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion acme/dns01.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,16 @@ func (s *DNS01Solver) Present(ctx context.Context, domain, zone, keyAuth string)
zone = rooted(zone)
}

results, err := s.provider.SetRecords(ctx, zone, []libdns.Record{rec})
// Append rather than Set: SetRecords replaces every record with the same
// name and type, which breaks certificates covering both a domain and its
// wildcard, since both challenges share the same _acme-challenge name.
var results []libdns.Record
var err error
if appender, ok := s.provider.(libdns.RecordAppender); ok {
results, err = appender.AppendRecords(ctx, zone, []libdns.Record{rec})
} else {
results, err = s.provider.SetRecords(ctx, zone, []libdns.Record{rec})
}
if err != nil {
return fmt.Errorf("adding temporary record for zone %q: %w", zone, err)
}
Expand Down