Skip to content

fix(ci): repair failing checks after lru security update - #3

Merged
hamdyaea merged 2 commits into
mainfrom
fix/ci-after-security-patch
Nov 3, 2026
Merged

hamdyaea merged 2 commits into
mainfrom
fix/ci-after-security-patch

Conversation

@hamdyaea

@hamdyaea hamdyaea commented Nov 3, 2026

Copy link
Copy Markdown
Owner

What failed after security PR #2

  • Check TOML: bundled vendor/num-prime/Cargo.toml did not pass Taplo formatting. Formatted with Taplo and verified locally.
  • Code Quality pre-commit: four hamdy-tools/*.sh files had a shebang but lacked executable Git mode. Marked them executable.
  • Code Quality, FreeBSD, OpenBSD Clippy: format!(...) appended to String in uu_pr; replaced with direct octal-digit appends without allocating.
  • WSL2: workflow downloaded a commit SHA from the upstream uutils/coreutils archive, which is not available there for fork-specific commits. Use ${{ github.repository }} and fail-fast curl.
  • Benchmarks: CodSpeed upload requires an upstream-linked project, and returns HTTP 401 on this fork. Keep the workflow for upstream only.
  • Android: hosted emulator cannot reliably allocate required resources in this fork; restrict the emulator workflow to upstream until a supported runner is configured.

Local verification

  • cargo +1.88.0 fmt --all -- --check: pass.
  • cargo +1.88.0 clippy -p uu_pr --lib --locked: pass (old toolchain emits existing unknown-lint warning).
  • cargo +1.88.0 test -p uu_pr --locked: pass.
  • cargo +1.88.0 test -p uu_factor --locked: 2 passed.
  • npx @taplo/cli fmt --check vendor/num-prime/Cargo.toml: pass.
  • YAML parse and git diff --check: pass.

No security fix was reverted. Cross-platform tests are retained where runner prerequisites are available.

@hamdyaea
hamdyaea merged commit 18d98c6 into main Nov 3, 2026
110 of 111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant