Repository navigation
fix(ci): repair failing checks after lru security update - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed after security PR #2
Check TOML: bundledvendor/num-prime/Cargo.tomldid not pass Taplo formatting. Formatted with Taplo and verified locally.Code Qualitypre-commit: fourhamdy-tools/*.shfiles had a shebang but lacked executable Git mode. Marked them executable.Code Quality, FreeBSD, OpenBSD Clippy:format!(...)appended toStringinuu_pr; replaced with direct octal-digit appends without allocating.WSL2: workflow downloaded a commit SHA from the upstreamuutils/coreutilsarchive, which is not available there for fork-specific commits. Use${{ github.repository }}and fail-fast curl.Benchmarks: CodSpeed upload requires an upstream-linked project, and returns HTTP 401 on this fork. Keep the workflow for upstream only.Android: hosted emulator cannot reliably allocate required resources in this fork; restrict the emulator workflow to upstream until a supported runner is configured.Local verification
cargo +1.88.0 fmt --all -- --check: pass.cargo +1.88.0 clippy -p uu_pr --lib --locked: pass (old toolchain emits existing unknown-lint warning).cargo +1.88.0 test -p uu_pr --locked: pass.cargo +1.88.0 test -p uu_factor --locked: 2 passed.npx @taplo/cli fmt --check vendor/num-prime/Cargo.toml: pass.git diff --check: pass.No security fix was reverted. Cross-platform tests are retained where runner prerequisites are available.