Repository navigation
fix: support .press() with Shift resulting in capitalisation - #238
Merged
cmorten merged 2 commits intoSep 29, 2026
Merged
Conversation
cmorten
reviewed
Sep 29, 2026
| ...keys.map((key) => `{${key}}`), | ||
| ...keys.map((key) => { | ||
| if (key.length === 1) { | ||
| return isShiftPressed ? key.toUpperCase() : key; |
Contributor
There was a problem hiding this comment.
General note that this will handle alpha capitalisation but isn’t a general solution for shift behaviour, which is would require keyboard map logic to handle US/UK/other layouts and so on - but as a starter for 10 feels adequate!
Contributor
|
Nice work 🚀 thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #8.
Details
Resolves an issue where calling
await virtual.press("Shift+a+b+c")produced"abc"instead of"ABC".When a
Shiftmodifier is present, single-character keys are now capitalized and passed directly without key descriptor braces (which previously caused user-event to default to unshifted lowercase keycodes). Also updates the integration test assertions intest/int/press.int.test.tsaccordingly.CheckList