Skip to content

add: support scheduler max delay in agent GMP commands - #1395

Merged
greenbonebot merged 4 commits into
mainfrom
add/support-updated-agent-config-format
Oct 26, 2026
Merged

greenbonebot merged 4 commits into
mainfrom
add/support-updated-agent-config-format

Conversation

@ozgen

@ozgen ozgen commented Oct 22, 2026

Copy link
Copy Markdown
Member

What

  • Add max_delay_seconds support to create and modify agent group commands.
  • Update agent configuration validation and XML generation to support cron entries with maximum delays.
  • Update unit tests for the new fields and configuration format.

Why

The Agent Controller now supports maximum scheduling delays for cron entries. These changes update python-gvm to support the new GMP fields and configuration format.

References

GEA-1955

Checklist

  • I have added tests for the changes

@ozgen
ozgen requested a review from a team as a code owner October 22, 2026 09:30
@greenbonebot
greenbonebot enabled auto-merge (rebase) October 22, 2026 09:30
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 5ce5c6d.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Conventional Commits Report

Type Number
Bug Fixes 1
Added 1

🚀 Conventional commits found.

@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.51%. Comparing base (1917eec) to head (5ce5c6d).

Files with missing lines Patch % Lines
gvm/protocols/gmp/requests/next/_agents.py 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1395      +/-   ##
==========================================
+ Coverage   98.42%   98.51%   +0.08%     
==========================================
  Files         106      106              
  Lines        6976     6983       +7     
  Branches     1273     1276       +3     
==========================================
+ Hits         6866     6879      +13     
+ Misses         77       74       -3     
+ Partials       33       30       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Add max_delay_seconds support to create and modify agent groups.
- Support structured scheduler cron entries with maximum delays.
- Update agent configuration validation and XML serialization.
- Update unit tests for the new fields and configuration format.
@ozgen
ozgen force-pushed the add/support-updated-agent-config-format branch from b852559 to cdfc596 Compare October 22, 2026 09:35
Comment thread gvm/protocols/gmp/requests/next/_agents.py
Comment thread gvm/protocols/gmp/requests/next/_agents.py
@ozgen
ozgen requested a review from a-h-abdelsalam October 26, 2026 12:19
@greenbonebot
greenbonebot merged commit 644217c into main Oct 26, 2026
25 of 26 checks passed
@greenbonebot
greenbonebot deleted the add/support-updated-agent-config-format branch October 26, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants