Repository navigation
Conversation
…-paste bug Change-Id: I495fc4a4ef5a6563806250567396e6b28f5a7f14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where developers copying code snippets from the
advanced-markers-graphicsand3d-marker-graphicssamples would encounter broken images because the local relative assets (./public/...orimages/...) are not present in their local environments or JSFiddle.Changes:
https://maps-docs-team.web.app/...) for the required assets (beachflag.png,google_logo_g.svg, and192px.svg).import.meta.urlVite pattern for the actual execution lines.Why this approach?
This pattern provides the best of both worlds:
npm start) continues to resolve the local assets seamlessly, avoiding the "chicken-and-egg" issue of requiring an asset to be deployed to production before it can be previewed locally.Affected Samples
advanced-markers-graphics3d-marker-graphicsTesting
npm startcontinue to work flawlessly.Fixes b/499325122
Change-Id: I495fc4a4ef5a6563806250567396e6b28f5a7f14