Skip to content

feat: Add enum values that were missing from FinishReason and ReinforcementTuningThinkingLevel #7175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add enum values that were missing from FinishReason and ReinforcementTuningThinkingLevel #7175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions agentplatform/_genai/feedback_entries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ def _update(
Args:
name (str): Required. Name of the Feedback Entry to update. Format:
`projects/{project}/locations/{location}/reasoningEngines/{resource_id}/feedbackEntries/{feedback_entry_id}`.
feedback_type (shared.FeedbackType): Optional. The type of feedback provided.
feedback_type (FeedbackType): Optional. The type of feedback provided.
config (UpdateRuntimeFeedbackEntryConfig): Optional. The configuration for updating the Feedback Entry.

Returns:
Expand Down Expand Up @@ -1245,7 +1245,7 @@ async def _update(
Args:
name (str): Required. Name of the Feedback Entry to update. Format:
`projects/{project}/locations/{location}/reasoningEngines/{resource_id}/feedbackEntries/{feedback_entry_id}`.
feedback_type (shared.FeedbackType): Optional. The type of feedback provided.
feedback_type (FeedbackType): Optional. The type of feedback provided.
config (UpdateRuntimeFeedbackEntryConfig): Optional. The configuration for updating the Feedback Entry.

Returns:
Expand Down
10 changes: 5 additions & 5 deletions agentplatform/_genai/types/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ class State(_common.CaseInSensitiveEnum):


class MemoryType(_common.CaseInSensitiveEnum):
"""The type of the memory."""
"""Represents the type of the memory. If not set, the `NATURAL_LANGUAGE_COLLECTION` type is used. If `STRUCTURED_COLLECTION` or `STRUCTURED_PROFILE` is used, then `structured_data` must be provided."""

MEMORY_TYPE_UNSPECIFIED = "MEMORY_TYPE_UNSPECIFIED"
"""Represents an unspecified memory type. This value should not be used."""
Expand Down Expand Up @@ -489,14 +489,14 @@ class QuotaState(_common.CaseInSensitiveEnum):


class FeedbackType(_common.CaseInSensitiveEnum):
"""The type of the feedback."""
"""The coarse-grained type of feedback provided by the user. Must be set to a value other than `FEEDBACK_TYPE_UNSPECIFIED`."""

FEEDBACK_TYPE_UNSPECIFIED = "FEEDBACK_TYPE_UNSPECIFIED"
"""Default value."""
"""This is the default value meaning the type has not been set."""
THUMBS_UP = "THUMBS_UP"
"""Indicates positive feedback (e.g., a "thumbs up")."""
"""Indicates positive feedback."""
THUMBS_DOWN = "THUMBS_DOWN"
"""Indicates a thumbs down feedback (e.g., a "thumbs down")."""
"""Indicates negative feedback."""


class Encoding(_common.CaseInSensitiveEnum):
Expand Down
Loading