fix: replay session_events into a scratch session and delete it afterwards - #7172
Merged
Merged
Conversation
product-auto-label
Bot
added
size: l
copybara-service
Bot
force-pushed
the
copybara_987536032
branch
3 times, most recently
from
October 1, 2026 13:20
1a97233 to
f15b685
Compare
…wards `AdkApp.async_stream_query(session_events=...)` raised `AttributeError` in the `vertexai` template and, in every template, left behind the managed session it created for the replayed events. The session is now read back before the replay and deleted when the query ends. Fixes #7118, fixes #7119 PiperOrigin-RevId: 991643489
copybara-service
Bot
force-pushed
the
copybara_987536032
branch
from
October 1, 2026 13:53
f15b685 to
3647753
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: replay session_events into a scratch session and delete it afterwards
AdkApp.async_stream_query(session_events=...)raisedAttributeErrorin thevertexaitemplate and, in every template, left behind the managed session itcreated for the replayed events. The session is now read back before the
replay and deleted when the query ends.
Fixes #7118, fixes #7119