Skip to content

fix: Keep AdkApp subclass, plugins and credential_service_builder in clone() #7162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Sep 23, 2026
Merged

fix: Keep AdkApp subclass, plugins and credential_service_builder in clone() #7162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions tests/unit/vertex_adk/test_reasoning_engine_templates_adk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,31 @@ def test_clone(self):
app_clone.set_up()
assert app_clone._tmpl_attrs.get("runner") is not None

def test_clone_preserves_subclass(self):
class CustomAdkApp(reasoning_engines.AdkApp):
pass

app = CustomAdkApp(
agent=Agent(name=_TEST_AGENT_NAME, model=_TEST_MODEL),
)
assert isinstance(app.clone(), CustomAdkApp)

def test_clone_preserves_plugins_and_credential_service_builder(self):
def credential_service_builder():
return None

app = reasoning_engines.AdkApp(
agent=Agent(name=_TEST_AGENT_NAME, model=_TEST_MODEL),
plugins=["test_plugin"],
credential_service_builder=credential_service_builder,
)
app_clone = app.clone()
assert app_clone._tmpl_attrs.get("plugins") == ["test_plugin"]
assert (
app_clone._tmpl_attrs.get("credential_service_builder")
is credential_service_builder
)

def test_register_operations(self):
app = reasoning_engines.AdkApp(
agent=Agent(name=_TEST_AGENT_NAME, model=_TEST_MODEL),
Expand Down
6 changes: 5 additions & 1 deletion vertexai/preview/reasoning_engines/templates/adk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,12 +846,16 @@ def clone(self):
"""Returns a clone of the ADK application."""
import copy

return AdkApp(
return self.__class__(
agent=copy.deepcopy(self._tmpl_attrs.get("agent")),
plugins=copy.deepcopy(self._tmpl_attrs.get("plugins")),
enable_tracing=self._tmpl_attrs.get("enable_tracing"),
session_service_builder=self._tmpl_attrs.get("session_service_builder"),
artifact_service_builder=self._tmpl_attrs.get("artifact_service_builder"),
memory_service_builder=self._tmpl_attrs.get("memory_service_builder"),
credential_service_builder=self._tmpl_attrs.get(
"credential_service_builder"
),
env_vars=self._tmpl_attrs.get("env_vars"),
)

Expand Down
Loading