[aelmanaa]

Removes the type-only node-fetch import from fallbackServiceStub, the follow-up gax-nodejs#1766 left for later ("In a follow-up we can remove node-fetch altogether"). The response of auth.fetch() is now typed as gaxios.GaxiosResponse, which is what google-auth-library 11 returns. Its body goes to pipeline() as a stream/web ReadableStream, a type-only import, with a comment on the two shapes it has at runtime. node-fetch is removed from google-gax's dependencies and from the gax entry in pnpm-lock.yaml.

google-gax never imported node-fetch at runtime. The compiled fallbackServiceStub.js is identical to main apart from one comment, and the declaration files are identical.

This doesn't remove node-fetch from users' dependency trees on its own. gaxios 8 still depends on it and loads it in Node.js, so it stays installed through google-auth-library and gcp-metadata until gaxios moves to native fetch (#9101, #8107).

• Issue opened first (cleanup: finish removing node-fetch types from fallbackServiceStub #7679)
• Tests and linter pass: 765 unit tests pass (bunInstall needs the full monorepo, which my sparse checkout lacks), and gts reports nothing new on the changed file
• Code coverage does not decrease: no runtime change
• Appropriate docs were updated: none affected

Fixes #7679

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Code Review

This pull request removes the node-fetch dependency from the gax package, updating fallbackServiceStub.ts to use gaxios.GaxiosResponse and cast the response body to WebReadableStream. The feedback points out a potential runtime TypeError if response.body is null, and suggests validating its presence before passing it to pipeline.

[gemini-code-assist]

If response.body is null (which is possible according to the Response type definition, e.g., if the server returns an empty body or on certain network conditions), passing it directly to pipeline will cause a synchronous TypeError at runtime.

To prevent this and ensure robust error handling, we should check if response.body is present before calling pipeline. If it is missing, we can destroy the streamArrayParser with a GoogleError.

          if (response.ok && rpc.responseStream) {
            if (!response.body) {
              streamArrayParser.destroy(
                new GoogleError('Response body is empty')
              );
              return;
            }
            pipeline(
              // `GaxiosResponse` is typed as the DOM `Response`, but the body
              // is a Node.js Readable when gaxios uses node-fetch and an async
              // iterable web ReadableStream when it uses native fetch; either
              // is a valid `pipeline` source in Node.js.
              response.body as WebReadableStream,

References

1. Always validate and reject missing or falsy arguments upfront before performing property checks, to prevent TypeErrors.