Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
WOFF2 decompresses untrusted fonts with the Brotli decoder. The bundled
brotlisubmodule is still at commit 533843e (2018), which predates the Brotli decoder fixes for CVE-2026-111497. This is the issue reported in #207.Change
brotlisubmodule to v1.2.1 (db24a98), the release that contains the decoder fix.depstarget invoked (make -C brotli lib).brotli/c/{common,dec,enc}/*.cwith the same flags already used for the rest of the Makefile and link the resulting objects into the tools and fuzzer archives..DEFAULT_GOAL := allso the new object pattern rule does not become the default goal.make cleannow removes the compiled Brotli objects.The CMake build is untouched; it still uses the system Brotli as before.
Testing
Built
woff2_compress,woff2_decompress,woff2_infoand both fuzzer archives successfully on macOS.Round-trip check with a system TTF:
The decompressed file loads with fontTools with the same 3,381 glyphs.
Fixes #207.