Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4587 +/- ##
==========================================
+ Coverage 98.59% 98.60% +0.01%
==========================================
Files 197 198 +1
Lines 18326 18511 +185
==========================================
+ Hits 18068 18253 +185
Misses 258 258 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
@adamcrews - please resolve conflicts and push the changes to this PR. |
adamcrews
force-pushed
the
feat/agents-variables
branch
from
September 23, 2026 16:37
badf91c to
2b93718
Compare
gmlewis
approved these changes
Sep 23, 2026
gmlewis
left a comment
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @adamcrews!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Add repository and organization Agents variables support on AgentsService, modeled on ActionsService variables and the Agents secrets client. Pin docs links via operation_overrides and send apiVersion 2026-03-10 with WithVersion on each request.
adamcrews
force-pushed
the
feat/agents-variables
branch
from
September 25, 2026 17:19
2b93718 to
6edcf19
Compare
Contributor
Author
|
@Not-Dhananjay-Mishra All feedback has been addressed. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds repository and organization Agents variables support on
AgentsService(list/get/create/update/delete variables, list repository organization variables, and selected-repository management), modeled on the existingActionsServicevariables client and the Agents secrets client from #4533. (I'm sorry I missed this on my last PR)The Agents endpoints are only served by the
2026-03-10API version, so each request sends it explicitly viaWithVersion.openapi_operations.yamlpins the documentation links for these operations throughoperation_overrides, scoped only to the new Agents variables operations — the rest of the client stays on2022-11-28.Reuses the existing
ActionsVariable/ request types for response and request bodies.GitHub API docs: https://docs.github.com/rest/agents/variables
Testing
gofmt,go vet,go generate ./..., andgo test ./...all pass.AI assistance disclosure
Cursor was used to draft the implementation & tests, but all code has been human reviewed and used in my github org.