Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements step 2 of the six-PR series proposed in #1002, following step 1 in #1041.
Timing-dependent MatMul autotuning can change floating-point results between otherwise identical evaluation runs. This adds fixed scheduling controls so baseline-versus-target comparisons can isolate changes from subsequent quantization work.
--matmul_schedule auto|fixed|fixed_min_k, keepingautoas the default.fixedselects the first legal candidate;fixed_min_kselects the candidate with the fewest K partitions, preserving candidate order for ties.matmul.cc, without adding scheduling mode state toMMAutoTune. Single-candidate tuning completes after its first measurement.MatMulEnv.Fixed schedules may be slower. Reproducibility requires the same binary, hardware, topology/thread settings, weights, and inputs;
--deterministiccontinues to control sampling separately.Dependency and review scope
#1041 is still open, so this branch is based on its head and targets
dev. The full PR diff currently includes step 1. The changes specific to step 2 are isolated in commit 8716968.Validation
fixedandfixed_min_k. Both modes produced exactly zero full-vocabulary KL divergence for every question, identical label logits, no prediction/answer changes, and 20/83 accuracy in each run.