When MxFp4Codec::QuantizeBlock encounters an all-zero input block, the early-out path zeroes kBlockSize (32) bytes instead of the encoded block size sizeof(MxFp4Stream) (17 bytes: 1 scale byte plus 16 nibble bytes). Writing 15 bytes past the end of the block corrupts the adjacent block when blocks are encoded out of order (such as across parallel batch boundaries in Compress or via packed_ofs sub-ranges) and writes past PackedEnd on the final block of a tensor. - #1045
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_991744020
branch
from
October 1, 2026 18:18
eb0747c to
7f2a825
Compare
…the early-out path zeroes `kBlockSize` (32) bytes instead of the encoded block size `sizeof(MxFp4Stream)` (17 bytes: 1 scale byte plus 16 nibble bytes). Writing 15 bytes past the end of the block corrupts the adjacent block when blocks are encoded out of order (such as across parallel batch boundaries in `Compress` or via `packed_ofs` sub-ranges) and writes past `PackedEnd` on the final block of a tensor. Zero `sizeof(MxFp4Stream)` bytes in the all-zero early-out path so block quantization stays within the bounds of a single encoded `MxFp4Stream` block. Based on #1044 PiperOrigin-RevId: 991799968
copybara-service
Bot
force-pushed
the
test_991744020
branch
from
October 1, 2026 18:32
7f2a825 to
1c570b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
MxFp4Codec::QuantizeBlockencounters an all-zero input block, the early-out path zeroeskBlockSize(32) bytes instead of the encoded block sizesizeof(MxFp4Stream)(17 bytes: 1 scale byte plus 16 nibble bytes). Writing 15 bytes past the end of the block corrupts the adjacent block when blocks are encoded out of order (such as across parallel batch boundaries inCompressor viapacked_ofssub-ranges) and writes pastPackedEndon the final block of a tensor.Zero
sizeof(MxFp4Stream)bytes in the all-zero early-out path so block quantization stays within the bounds of a single encodedMxFp4Streamblock.Based on
#1044