Repository navigation
fix(fdt_mut): use correct slice length on FdtMut=>Fdt conversion - #100
Merged
Merged
Conversation
`Fdt` assumes that `data.len() == totalsize`. If the slice capacity is bigger than the FDT blob itself, this breaks the assumption. This commit ensures the slice passed to `Fdt` is exactly `totalsize` bytes long. This mainly affects `Fdt::data()` which could return garbage data after the end of the FDT blob.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage 93.16% 93.17%
=======================================
Files 26 26
Lines 3336 3339 +3
=======================================
+ Hits 3108 3111 +3
Misses 228 228 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
qwandor
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(fdt_mut): use correct slice length on FdtMut=>Fdt conversion
Fdtassumes thatdata.len() == totalsize. If the slice capacity isbigger than the FDT blob itself, this breaks the assumption. This commit
ensures the slice passed to
Fdtis exactlytotalsizebytes long.This mainly affects
Fdt::data()which could return garbage data afterthe end of the FDT blob.