Repository navigation
hwcaps: check elf_aux_info() return value in GetElfHwcapFromElfAuxInfo - #475
Merged
Merged
Conversation
Contributor
Author
|
Ping. |
Collaborator
|
Sorry I missed the patch... Can you clang-format it please? |
brad0
force-pushed
the
elf_aux_info_check
branch
2 times, most recently
from
October 20, 2026 08:40
8bbf9e2 to
fbcad8a
Compare
Contributor
Author
Done. That formatting is horrible. |
gchatelet
reviewed
Oct 20, 2026
Do not rely on elf_aux_info() leaving the output buffer untouched on failure, since that is not part of its documented contract. Check the return value and set hwcap to 0 on error.
brad0
force-pushed
the
elf_aux_info_check
branch
from
October 20, 2026 08:50
fbcad8a to
4b6a1fe
Compare
Collaborator
|
Thx @brad0 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not rely on elf_aux_info() leaving the output buffer untouched on
failure, since that is not part of its documented contract. Check the
return value and set hwcap to 0 on error.