Repository navigation
Match Palo Alto GRE and SCTP rules by IP protocol number - #376
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GRE and SCTP terms currently reference PAN-OS built-in applications instead of matching their IP protocol numbers. Generate
ip-protocol-greandip-protocol-sctpcustom applications usingident-by-ip-protocolvalues 47 and 132. The existing mixed-protocol split keeps these applications separate from TCP/UDP service rules.The generated applications are reused across policies. Explicit GRE/SCTP port filters are rejected: PAN-OS service objects only support TCP/UDP, and silently discarding a port restriction would broaden the policy. Document these rules and add XML-level coverage for IPv4, IPv6, mixed protocols, shared applications, and unsupported ports.
Addresses the GRE/SCTP cases in #273. Other protocol mappings are unchanged.
Validation: the new protocol cases failed before the fix. The full suite passes (1721 tests and 19 subtests); after formatting cleanup, all 50 Palo Alto tests and six subtests pass. No new Pylint findings compared with the base using the repository configuration. The XML field matches Palo Alto's SDK schema (https://github.com/PaloAltoNetworks/pan-os-python/blob/develop/panos/objects.py). No physical PAN-OS firewall was available for deployment validation.