Repository navigation
Аудит перед публикацией: горячие клавиши, валидация, тёмная тема, новые тесты - #5
Merged
Merged
Conversation
- shortcuts: Alt+Shift+P and Alt+Shift+X are reserved by Chrome for tab groups (chrome/browser/ui/accelerator_table.cc) and were not assigned; now Alt+Shift+F (profiler), Alt+Shift+K (popup), Alt+Shift+D (debugger) - options: invalid (RFC 6265) and duplicate cookie names/values are not saved, the error names the value; popup rejects invalid custom IDE key - options/popup follow the browser dark theme (color-scheme), lang attribute - icon is updated when host permission is revoked (permissions.onRemoved) - store listing: private windows / incognito work after the user allows it - tests: shortcuts, validation, Firefox containers, private windows, IPv6 host, Chrome incognito Passed locally: Chromium 141 17/17 (3 runs), Firefox 157.0.1 14/14 (3 runs), Firefox 153.4.0esr 14/14 (2 runs), web-ext lint 0 errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011ZZMU6eeKUpne5HfQBAxoT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Найдено и исправлено
Alt+Shift+PиAlt+Shift+XChrome резервирует для групп вкладок (chrome/browser/ui/accelerator_table.cc), поэтому в Chrome работал толькоAlt+Shift+D. Новые сочетания:Alt+Shift+F— профайлер,Alt+Shift+K— popup,Alt+Shift+D— отладчик. Сам Firefox сочетанияAlt+Shift+букване занимает (browser-sets.inc.xhtml).;, кавычки и т. п.) и одинаковые имена у двух режимов — тогда браузер отказывался ставить cookie. Теперь сохранение блокируется, а ошибка показывает конкретное значение. Свой IDE key в popup проверяется так же.color-scheme).permissions.onRemoved), у страниц задан атрибутlang.Проверено, ошибок нет
[::1]: включение и выключение работают в обоих браузерах.evalиinnerHTML.Тесты
web-ext lint(по папке и по распакованному zip): 0 ошибок, 1 ожидаемое предупреждение.CI не запускается из-за блокировки аккаунта по оплате.
🤖 Generated with Claude Code
https://claude.ai/code/session_011ZZMU6eeKUpne5HfQBAxoT
Generated by Claude Code