Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The dependency declaration and lockfile update are complete, consistent, and appropriately constrained for the existing renderer API.
Review effort: Balanced
Findings: None
What changed in this PR
Declares the RDoc version range required for reliable runtime loading and rendering.
Changes:
- Adds
rdoc < 8as a runtime dependency. - Updates the lockfile’s local gem specification.
| File | Description |
|---|---|
github-markup.gemspec |
Declares the compatible RDoc runtime dependency. |
Gemfile.lock |
Records the new dependency for the local package. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
require 'github/markup'unconditionally loads the RDoc renderer, but the gemspec does not declarerdocas a runtime dependency. Loading fails withLoadError: cannot load such file -- rdocin a runtime-only bundle on Ruby 4.0. The development bundle includes RDoc and masks the missing declaration.Declare
rdoc < 8as a runtime dependency and update the local package entry inGemfile.lock. RDoc 8 changes theRDoc::Markup::ToHtmlconstructor used by the renderer, so an unbounded dependency would fix loading but break RDoc rendering withArgumentError.This change targets the current 6.0.0 source. Consumers such as
gollum-libthat requiregithub-markup ~> 4.0would need a corresponding 4.x backport and release.