Require stable Freno recovery - #37
Draft
pradeepkintali wants to merge 2 commits into
Draft
pradeepkintali wants to merge 2 commits into
pradeepkintali wants to merge 2 commits into
Conversation
After a rejection, require consecutive healthy checks before releasing work and keep normal sustained throttling out of the circuit breaker failure path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0fbc396f-32f9-449a-8537-6264e8665c31
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0fbc396f-32f9-449a-8537-6264e8665c31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WaitedTooLongas normal sustained throttling rather than a circuit-breaker failureWhy
During availability#6027, an oscillating lag signal let each batch proceed on the first passing sample. Longer wait windows therefore made the gate more permissive. This change requires stable recovery after throttling while keeping transport and Freno decision errors on the circuit-breaker failure path.
Validation
bundle exec rake test— 43 runs, 168 assertionsbundle exec rubocop lib/freno/throttler.rb test/freno/throttler_test.rbFull-repository RuboCop is currently obscured on this Windows checkout by pre-existing CRLF offenses in untouched files.
Tracking: github/database-infrastructure#8726
Related: github/availability#6027