Hi & thanks for the very cool project !
I've been using vscode's Agents Window with custom BYOK endpoints with
"chat.agentHost.allowSignedOutWhenUsable": true,
"chat.agentHost.byokModels.enabled": true,
which means copilot-sdk is configured to use the endpoint provided by vscode in https://github.com/microsoft/vscode/blob/main/src/vs/platform/agentHost/node/copilot/byokLmProxyService.ts, which url is http://127.0.0.1/......
This is working pretty fine, but there's a very annoying behavior: when setting http.proxy (in vscode), HTTP_PROXY in copilot-sdk, the copilot-sdk tries to use the HTTP proxy to connect to 127.0.0.1. This is obviously easily fixable by adding NO_PROXY=127.0.0.1,::1,localhost, but it feels like a very weird behavior from a user standpoint.
I would argue that 127.0.0.1,localhost,::1 should be automatically appended to NO_PROXY on the copilot-sdk side, as is usually done by web browsers for instance (chrome/firefox). It could be done in vscode directly but I think it makes more sense here.
What do you think? Thanks a lot for reading !
Hi & thanks for the very cool project !
I've been using vscode's Agents Window with custom BYOK endpoints with
which means copilot-sdk is configured to use the endpoint provided by vscode in https://github.com/microsoft/vscode/blob/main/src/vs/platform/agentHost/node/copilot/byokLmProxyService.ts, which url is
http://127.0.0.1/......This is working pretty fine, but there's a very annoying behavior: when setting
http.proxy(in vscode),HTTP_PROXYin copilot-sdk, the copilot-sdk tries to use the HTTP proxy to connect to 127.0.0.1. This is obviously easily fixable by addingNO_PROXY=127.0.0.1,::1,localhost, but it feels like a very weird behavior from a user standpoint.I would argue that
127.0.0.1,localhost,::1should be automatically appended toNO_PROXYon the copilot-sdk side, as is usually done by web browsers for instance (chrome/firefox). It could be done invscodedirectly but I think it makes more sense here.What do you think? Thanks a lot for reading !