Repository navigation
fix(core): preserve Hermes internal bytecode frames in Expo - #6848
Merged
alwx merged 5 commits intoOct 8, 2026
Merged
Conversation
Trancever
marked this pull request as ready for review
October 7, 2026 08:14
Trancever
requested review from
alwx,
antonis and
lucas-zimerman
as code owners
October 7, 2026 08:14
alwx
requested changes
Oct 7, 2026
alwx
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your PR, @Trancever! One small thing left before I merge it.
alwx
requested changes
Oct 8, 2026
Trancever
commented
Oct 8, 2026
Trancever
commented
Oct 8, 2026
alwx
enabled auto-merge (squash)
October 8, 2026 09:26
alwx
approved these changes
Oct 8, 2026
alwx
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your contribution, @Trancever!
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Preserve Hermes
InternalBytecode.jsframes asapp:///InternalBytecode.jswithin_app: falsebefore Expo rewrites JavaScript filenames to the application bundle. Recognize both bare and slash-prefixed filenames after path normalization.💡 Motivation and Context
Follow-up to #3348 and #3518. The existing exclusion runs after Expo's early returns and only matches
/InternalBytecode.js. Hermes promise helpers can therefore be attributed to the application bundle, causing invalid source-map lookups and incorrect grouping of unrelated errors.💚 How did you test it?
in_appvalues with a failing test before applying the fix.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
🚨 PR created with AI assistance, but it was carefully reviewed by Dweet team where this patch is already used on prod in an Expo app.