Repository navigation
test(e2e): Re-enable iOS view_names assertion in captureMessage test - #6846
Merged
Merged
Conversation
The JS captureMessage event's `view_names` is set entirely in JS from the clean React Navigation `route.name`, matching the already-enabled Android assertion. The generated route-key hash referenced by the old TODO no longer appears, so re-enable the assertion with the clean route name. Closes #6844 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
📲 Install BuildsAndroid
|
antonis
marked this pull request as ready for review
October 6, 2026 09:05
alwx
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Re-enables the previously commented-out
view_namesassertion in the iOScaptureMessagee2e test, asserting the clean route name:This matches the already-enabled, passing assertion in the Android variant (
captureMessage.test.android.manual.ts).💡 Motivation and Context
Closes #6844
💚 How did you test it?
CI
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps