Repository navigation
chore: Clean up non-actionable TODOs - #6843
Merged
Merged
Conversation
Resolve TODOs that aren't actionable as code changes — reframe the ones that document real behavior/limitations into plain notes, and drop the one that's self-explanatory. Comment-only; no behavior change. - RNSentryStart.m: the two "resolve dev-server / spotlight URL automatically for options-file init" TODOs become behavior notes (these URLs are resolved by the JS layer on auto-init; for options-file init they come from the options). The auto-resolution is a possible future enhancement, tracked separately. - sentryApi.js (maestro): the "reach out to Maestro & GraalJS" TODO becomes an explanation of why we busy-wait (the GraalJS runtime has no setTimeout/Promise). - expo sample: "TODO: No working in Expo Go App" becomes a plain note. - parseEnvelope.ts (e2e): drop the "parse when needed" TODO; the binary handling is self-explanatory. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
antonis
marked this pull request as ready for review
October 6, 2026 07:59
alwx
approved these changes
Oct 6, 2026
Reframe the FIXME in captureAppStartCrash.test.ios.manual.ts into a note explaining the expected sentry-cocoa behavior: app-start crashes are flushed synchronously mid-init so sdk.integrations only reflects integrations ordered before the crash integration. Closes #6845 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Cleans up TODOs that aren't actionable as code changes. Each either documents real behavior/a limitation (reframed to a plain note so the "why" is kept) or was self-explanatory (removed). Comment-only — no behavior change.
packages/core/ios/RNSentryStart.mdev-packages/e2e-tests/maestro/utils/sentryApi.jssetTimeout/Promise (also fixed aGrallJStypo).samples/expo/app/(tabs)/index.tsxsamples/react-native/e2e/utils/parseEnvelope.tsreplay_videois self-explanatory.samples/react-native/e2e/tests/captureAppStartCrash/captureAppStartCrash.test.ios.manual.tsSentryCrashIntegration), sosdk.integrationsonly reflects integrations ordered before the crash integration (SessionReplay). Expected cocoa behavior. Closes #6845.💡 Motivation and Context
TODO cleanup pass
💚 How did you test it?
N/A
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps