Repository navigation
API: Properly quote name - #49
Merged
Merged
Conversation
Member
|
Rather than doing this manually, can you use |
RFC 5322, "Internet Message Format" specifies in §3.4 Address
Specification that commas separate the addresses in a list. But some
people use comma in their name:
pwclient list -S "$series_id" -f '%{submitter}'
Surname, Name <foo@example.com>
Using passing the output to git send-email causes it to fail (at least
dovecot refuses to send):
git send-email --to="Surname, Name <foo@example.com>" ...
5.5.4 Invalid TO: Missing domain
Properly quoting with email.utils.formataddr helps:
pwclient list -S "$series_id" -f '%{submitter}'
"Surname, Name" <foo@example.com>
git send-email --to='"Surname, Name" <foo@example.com>" ...
To: "Surname, Name" <foo@example.com>
Result: 250
Signed-off-by: Petr Vorel <pvorel@suse.cz>
pevik
force-pushed
the
properly-quote-name
branch
from
October 15, 2026 13:20
f0f501b to
894f69b
Compare
stephenfin
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 5322, "Internet Message Format" specifies in §3.4 Address Specification that commas separate the addresses in a list. But some people use comma in their name:
Using passing the output to git send-email causes it to fail (at least dovecot refuses to send):
Quoting name helps:
@stephenfin Or, do you want this formatting to have it's own formatting?