Repository navigation
fix: the README's own-model example and two fixtures name no lab machine (greenhouse evidence/1144) - #170
Merged
Conversation
…ine (greenhouse evidence/1144) The README showed MILPA_AGENT_BASE_URL set to the mDNS name of a lab machine, and two fixtures of the tests used it as an endpoint. All three become model.example, a reserved name that is nobody's. This package's archive carries its tests, so all three travelled in it. A public repository names no machine it was written on (greenhouse evidence/1144), and a published package carries no host identifier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A public repository names no machine it was written on, and a published package carries no host identifier (greenhouse
evidence/1144). This one did, in three lines, and — because the skeleton's archive carries its tests — all three travelled in it.README.md, «Your own model works too»MILPA_AGENT_BASE_URLset to the mDNS name of a lab machinehttp://model.example:11434tests/Operations/AgentOperationTest.php,tests/Support/OperationsTest.phphttps://model.examplemodel.exampleis a reserved name that is nobody's: a reader replaces it with their own. No code changes.After the change
The scanner that found it — every tracked file of this branch, and
git archive HEAD(what the registry would serve) — returns zero lines that name a machine.Nothing is released from here.